Skip to content

Fix typo in SetupNewProposer.s.sol #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

VitalikBerashvili
Copy link

Title

Fix typo in SetupNewProposer.s.sol

Description

This pull request fixes a typo in the SetupNewProposer.s.sol file. The word "wiht" has been corrected to "with."

Changes

  • Corrected the typo in the comment: "Deploy L2OutputOracle new implementation wiht the new submission interval" to "Deploy L2OutputOracle new implementation with the new submission interval."

Impact

This is a documentation fix and does not affect the functionality of the code.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 4, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wbnns wbnns added the base protocol review To be reviewed by the Base web team label Apr 19, 2025
@wbnns
Copy link
Contributor

wbnns commented Apr 19, 2025

Thank you, fixing in #270 🙏

@wbnns wbnns closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base protocol review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants